fix(review): address code review findings — tool conflicts, dual inputs, pin animation

1. TEXT and ERASER tool clicks now suppressed during review mode via
   reviewMode flag on ToolContext (read from ref for live value)
2. Object-comment input hidden when draftPin is active — only one
   creation input visible at a time
3. PinOverlay entrance animation removed — focus styling (scale 1.15x,
   alpha changes) no longer fights with fade-in animation loop
This commit is contained in:
Hiren Kangad
2026-03-12 22:09:12 +05:30
parent 16a677dc89
commit 318b7358e1
4 changed files with 14 additions and 28 deletions
+4
View File
@@ -49,6 +49,8 @@ export interface ToolContext {
textEditor?: TextEditor;
/** Switch back to select tool after placing text. */
switchToSelect?: () => void;
/** When true, destructive/creative tool clicks (TEXT, ERASER) are suppressed. */
reviewMode?: boolean;
}
export function activateTool(
@@ -82,6 +84,7 @@ export function activateTool(
container.style.cursor = 'text';
const onClick = (e: PointerEvent) => {
if (ctx.reviewMode) return; // Review mode suppresses text creation
const rect = container.getBoundingClientRect();
const world = viewport.toWorld(e.clientX - rect.left, e.clientY - rect.top);
@@ -154,6 +157,7 @@ export function activateTool(
selection.transformBox.update([]);
const onClick = (e: PointerEvent) => {
if (ctx.reviewMode) return; // Review mode suppresses eraser
const rect = container.getBoundingClientRect();
const world = viewport.toWorld(e.clientX - rect.left, e.clientY - rect.top);
const hit = selection._hitTest(world.x, world.y);