fix(refboard): server posters respect culling budget + fix temp dir leak

1. Server posters no longer auto-load in VideoSprite constructor.
   loadServerPoster() is now public and called by the culling system
   only when within MAX_POSTER_VIDEOS budget. Videos outside the
   budget stay as placeholders regardless of server poster availability.

2. video-utils cleanup() now uses statSync to distinguish files from
   directories, unlinks files first, then rmdirs. Previously tmpDir
   was passed through path.dirname() which resolved to /tmp instead
   of the created temp directory.
This commit is contained in:
Hiren Kangad
2026-03-10 12:19:43 +05:30
parent 198497381f
commit e3c3aaf558
3 changed files with 33 additions and 18 deletions
+19 -10
View File
@@ -112,18 +112,27 @@ function extractPoster(buffer) {
});
}
function cleanup(...files) {
for (const f of files) {
try { unlinkSync(f); } catch { /* ignore */ }
}
// Try removing parent dirs (they're temp dirs we created)
for (const f of files) {
/**
* Clean up temp files and directories.
* Pass file paths first, then the temp directory last.
* Files are unlinked, then the directory is removed.
*/
function cleanup(...paths) {
const dirs = [];
// First pass: unlink files, collect directories
for (const p of paths) {
try {
const dir = path.dirname(f);
if (dir.includes('refboard-')) {
require('fs').rmdirSync(dir);
const stat = require('fs').statSync(p);
if (stat.isDirectory()) {
dirs.push(p);
} else {
unlinkSync(p);
}
} catch { /* ignore — dir may not be empty or already removed */ }
} catch { /* already gone */ }
}
// Second pass: remove directories (now empty)
for (const d of dirs) {
try { require('fs').rmdirSync(d); } catch { /* ignore */ }
}
}